Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content migration] - HRMP Channels #56

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Sep 25, 2024

This PR incorporates content from the polkadot-ecosystem-docs-draft repository.

Migrated content:

  • HRMP Channels

@0xLucca 0xLucca changed the title Add hrmp-channels section [Content migration] - HRMP Channels Sep 25, 2024
@0xLucca
Copy link
Collaborator Author

0xLucca commented Sep 25, 2024

@eshaben Please check if this section is located where expected. It is slightly different from what we have in the IA sheet. Develop > Parachain Developers > Interoperability > Open Message Passing Channels.

@eshaben
Copy link
Collaborator

eshaben commented Sep 25, 2024

@0xLucca all good from my end on the AI. We'll revisit later as needed, but I think it's good for now 👍

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The JSON file needs formatting, but that'll get fixed automatically once the husky pre-commit hook is in and working 🙂

@0xLucca 0xLucca merged commit 162bd64 into master Sep 26, 2024
@0xLucca 0xLucca deleted the 0xlucca/hrmp-channels branch September 26, 2024 10:57
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, will test fully when opening channels for educhain ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants