Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(courses): switch courses with no id to a previous edition, if available #532

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix(courses): switch courses with no id to a previous edition, if available #532

merged 4 commits into from
Jan 23, 2025

Conversation

emacoricciati
Copy link
Contributor

Closes #512

@emacoricciati emacoricciati requested a review from a team as a code owner October 29, 2024 09:22
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Oct 29, 2024
Bri74
Bri74 requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Bri74 Bri74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that if a course is switched to the previous edition, it would appear on the homepage (if not hidden), like all the others. Right now, it seems to remain only under "see all," even if it's not hidden.

@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Nov 25, 2024
@emacoricciati emacoricciati force-pushed the hotfix/512-switch-course-with-no-id-to-previous-edition branch from 7da62ae to 3081bfa Compare January 22, 2025 12:42
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 22, 2025
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 23, 2025
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 23, 2025
@Bri74 Bri74 merged commit 3fd1e75 into main Jan 23, 2025
9 checks passed
@Bri74 Bri74 deleted the hotfix/512-switch-course-with-no-id-to-previous-edition branch January 23, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bri74 Bri74 Bri74 approved these changes

Assignees
No one assigned
Labels
cc-fix PR includes fix commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch courses with no id to the previous edition, if available
2 participants
@emacoricciati @Bri74