Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): enable login even when fcm is not enabled, but display warning #515

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

QcFe
Copy link
Member

@QcFe QcFe commented Jul 26, 2024

This PR adds a check around the fcm token retrieval that possibly outputs a warning if retrieval fails (and we're not in dev mode).

Fixes #513

@QcFe QcFe requested review from umbopepato and Bri74 July 26, 2024 13:55
@QcFe QcFe requested a review from a team as a code owner July 26, 2024 13:55
@github-actions github-actions bot added the cc-fix PR includes fix commit label Jul 26, 2024
@QcFe QcFe requested a review from lpezzolla July 26, 2024 16:17
@Bri74 Bri74 merged commit 7db8d40 into main Jul 30, 2024
9 checks passed
@Bri74 Bri74 deleted the fix/fcmUnsupportedWarning branch July 30, 2024 07:52
@QcFe QcFe mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cc-fix PR includes fix commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inability to login without Google Play services installed
2 participants