Use window._paq
instead of a local reference of _paq
.
#10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I traced back the problem of #5 that prevented the MediaAnalytics plugin from initializing:
window._paq
to configure Matomo.window._paq
and replaces it: https://github.com/matomo-org/matomo/blob/d0e6442ccbd7cb4a6f8214731fdd9d70b4cea4bb/js/piwik.js#L7528scanForMedia
:paella-user-tracking/src/plugins/es.upv.paella.matomo.userTrackingDataPlugin.js
Lines 145 to 147 in 0efda07
window._paq
. So it does nothing and the MediaAnalytics plugin never gets started.There are several other potential occurrences of this problem. For example
paella-user-tracking/src/plugins/es.upv.paella.matomo.userTrackingDataPlugin.js
Lines 95 to 100 in 0efda07