Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use window._paq instead of a local reference of _paq. #10

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

luniki
Copy link
Contributor

@luniki luniki commented Jun 7, 2024

I traced back the problem of #5 that prevented the MediaAnalytics plugin from initializing:

There are several other potential occurrences of this problem. For example

bindEvent(this.player, Events.COOKIE_CONSENT_CHANGED, () => {
this.player.log.debug('Matomo: Cookie consent changed.');
if (this.player.cookieConsent.getConsentForType(this.config.cookieType)) {
// _paq.push(['rememberConsentGiven']);
_paq.push(['rememberCookieConsentGiven']);
}

@miesgre miesgre merged commit 30cca9b into polimediaupv:main Jun 8, 2024
@snoesberger
Copy link
Contributor

Thanks for fixing this! I did test this PR with Opencast and now statistics data is also send for the media analytics plugin.

Unfortunately, the title information is still missing as I mentioned already here. In order to really benefit from the Media Analysis plugin, this issue needs to be solved: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants