fix:[动态配置]修复config_flow递归加读锁导致的死锁问题 (#212) (#215) #292
chuntaojunAnnotations
66 warnings
|
Run Revive Action (1.15.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Revive Action (1.15.x):
pkg/plugin/loadbalancer/loadbalancer.go#L18
should have a package comment
|
|
Run Revive Action (1.15.x):
plugin/loadbalancer/hash/config.go#L18
should have a package comment
|
|
Run Revive Action (1.15.x):
plugin/loadbalancer/common/half_open.go#L18
should have a package comment
|
|
Run Revive Action (1.15.x):
plugin/loadbalancer/weightedrandom/wr.go#L18
should have a package comment
|
|
Run Revive Action (1.15.x):
plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.15.x):
plugin/location/local/local.go#L18
should have a package comment
|
|
Run Revive Action (1.15.x):
plugin/location/local/local.go#L35
exported function New should have comment or be unexported
|
|
Run Revive Action (1.15.x):
plugin/servicerouter/filteronly/router.go#L68
parameter 'clusters' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.15.x):
plugin/servicerouter/filteronly/router.go#L68
parameter 'routeInfo' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.15.x):
pkg/flow/detect/ticker.go#L111
context.Context should be the first parameter of a function
|
|
Run Revive Action (1.18.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Revive Action (1.18.x):
api_config.go#L122
comment on exported function NewConfigGroupAPIByFile should be of the form "NewConfigGroupAPIByFile ..."
|
|
Run Revive Action (1.18.x):
api_config.go#L111
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
|
|
Run Revive Action (1.18.x):
plugin/circuitbreaker/common/half_open.go#L135
exported const ToClose should have comment (or a comment on this block) or be unexported
|
|
Run Revive Action (1.18.x):
api_config.go#L133
comment on exported function NewConfigGroupAPIByContext should be of the form "NewConfigGroupAPIByContext ..."
|
|
Run Revive Action (1.18.x):
plugin/configfilter/crypto/rsa/rsa.go#L30
type name will be used as rsa.RSAKey by other packages, and that stutters; consider calling this Key
|
|
Run Revive Action (1.18.x):
plugin/loadbalancer/common/half_open.go#L18
should have a package comment
|
|
Run Revive Action (1.18.x):
test/ratelimit/mock_server.go#L32
comment on exported const OperationInit should be of the form "OperationInit ..."
|
|
Run Revive Action (1.18.x):
examples/watch/instance/notify/main.go#L76
exported type TestListener should have comment or be unexported
|
|
Run Revive Action (1.18.x):
test/ratelimit/remote_normal_suite.go#L35
comment on exported type RemoteNormalTestingSuite should be of the form "RemoteNormalTestingSuite ..." (with optional leading article)
|
|
Run Revive Action (1.18.x):
test/ratelimit/window_expire_suite.go#L31
comment on exported type WindowExpireTestingSuite should be of the form "WindowExpireTestingSuite ..." (with optional leading article)
|
|
Run Revive Action (1.19.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Revive Action (1.19.x):
examples/watch/instance/notify/main.go#L76
exported type TestListener should have comment or be unexported
|
|
Run Revive Action (1.19.x):
benchmark/benchsimple/main.go#L89
comment on exported type Durations should be of the form "Durations ..." (with optional leading article)
|
|
Run Revive Action (1.19.x):
pkg/algorithm/hash/base.go#L32
type name will be used as hash.HashFuncWithSeed by other packages, and that stutters; consider calling this FuncWithSeed
|
|
Run Revive Action (1.19.x):
examples/watch/service/notify/main.go#L44
exported type TestListener should have comment or be unexported
|
|
Run Revive Action (1.19.x):
pkg/flow/configuration/group_repo.go#L131
exported method ConfigGroupRepo.AddChangeListener should have comment or be unexported
|
|
Run Revive Action (1.19.x):
pkg/plugin/loadbalancer/util.go#L25
parameter 'ctx' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.19.x):
plugin/location/remoteservice/remoteservice.go#L35
exported function New should have comment or be unexported
|
|
Run Revive Action (1.19.x):
pkg/plugin/loadbalancer/loadbalancer.go#L18
should have a package comment
|
|
Run Revive Action (1.19.x):
pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
|
|
Run Revive Action (1.19.x):
plugin/servicerouter/nearbybase/nearby.go#L189
exported method NearbyBasedInstancesFilter.GetLevel should have comment or be unexported
|
|
Run Revive Action (1.16.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Revive Action (1.16.x):
benchmark/benchsimple/main.go#L181
struct field maxQps should be maxQPS
|
|
Run Revive Action (1.16.x):
benchmark/benchsimple/main.go#L71
var maxQps should be maxQPS
|
|
Run Revive Action (1.16.x):
benchmark/benchsimple/main.go#L414
var useQpsLimit should be useQPSLimit
|
|
Run Revive Action (1.16.x):
benchmark/benchsimple/main.go#L239
func runQpsLimitFeature should be runQPSLimitFeature
|
|
Run Revive Action (1.16.x):
benchmark/benchmain/main.go#L47
const operationRpcNaming should be operationRPCNaming
|
|
Run Revive Action (1.16.x):
benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
|
|
Run Revive Action (1.16.x):
pkg/model/pb/metric/code.go#L18
should have a package comment
|
|
Run Revive Action (1.16.x):
pkg/model/pb/metric/code.go#L28
exported const ExecuteSuccess should have comment (or a comment on this block) or be unexported
|
|
Run Revive Action (1.16.x):
pkg/plugin/loadbalancer/loadbalancer.go#L18
should have a package comment
|
|
Run Revive Action (1.16.x):
pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
|
|
Run Revive Action (1.20.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Revive Action (1.20.x):
pkg/plugin/metrics/proxy.go#L18
should have a package comment
|
|
Run Revive Action (1.20.x):
test/tools/tools_vet.go#L18
should have a package comment
|
|
Run Revive Action (1.20.x):
plugin/servicerouter/filteronly/router.go#L68
parameter 'routeInfo' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.20.x):
plugin/servicerouter/filteronly/router.go#L18
should have a package comment
|
|
Run Revive Action (1.20.x):
plugin/weightadjuster/ratedelay/ratedelay.go#L18
should have a package comment
|
|
Run Revive Action (1.20.x):
plugin/servicerouter/filteronly/router.go#L68
parameter 'clusters' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.20.x):
test/common/constant.go#L18
should have a package comment
|
|
Run Revive Action (1.20.x):
test/common/constant.go#L41
exported var ServerSwitchSuitServerPort should have comment or be unexported
|
|
Run Revive Action (1.20.x):
test/common/constant.go#L21
exported const ConsumerSuitServerPort should have comment (or a comment on this block) or be unexported
|
|
Run Revive Action (1.20.x):
plugin/location/local/local.go#L18
should have a package comment
|
|
Run Revive Action (1.17.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Revive Action (1.17.x):
pkg/plugin/loadbalancer/util.go#L25
parameter 'ctx' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.17.x):
pkg/plugin/loadbalancer/loadbalancer.go#L18
should have a package comment
|
|
Run Revive Action (1.17.x):
pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
|
|
Run Revive Action (1.17.x):
pkg/plugin/register/plugins.go#L21
a blank import should be only in a main or test package, or have a comment justifying it
|
|
Run Revive Action (1.17.x):
pkg/plugin/location/location.go#L27
exported const ProviderName should have comment (or a comment on this block) or be unexported
|
|
Run Revive Action (1.17.x):
pkg/plugin/metrics/proxy.go#L18
should have a package comment
|
|
Run Revive Action (1.17.x):
pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
|
|
Run Revive Action (1.17.x):
plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
|
|
Run Revive Action (1.17.x):
plugin/loadbalancer/common/half_open.go#L18
should have a package comment
|
|
Run Revive Action (1.17.x):
test/common/constant.go#L21
exported const ConsumerSuitServerPort should have comment (or a comment on this block) or be unexported
|