-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstring improvements & enable lints #4161
Conversation
Thabks @stinodego. Can you do a rebase? Then I merge it in. |
@stinodego thanks for working on this! good to know there is a easy solution to #3975. please do add note about closing #3975 if this PR covers what I was raising in that issue (seems like it does to me) |
Done! Thanks guys. |
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 457 457
Lines 75728 75728
=======================================
Hits 59637 59637
Misses 16091 16091 Continue to review full report at Codecov.
|
Builds upon #4155
Fixes #3975
Changes:
flake8-docstrings
in the CI. You will now get slapped if you forget to add a blank line before the end of your docstring 😄 Not all lints are enabled yet (see notes below).Notes:
If it turns out there are some controversial lints that bug you while documenting your code, let's discuss and we can adjust the linter as necessary. This is just a first attempt at enforcing some uniformity!