Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for open issues #20857

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

lukemanley
Copy link
Contributor

Tests added for the following open issues that appear to already be fixed:

closes #2732
closes #6968
closes #7737
closes #9461
closes #12950
closes #13759
closes #15014
closes #17006

These open issues also appear to be fixed and already have tests. Just noting the existing tests in order to close these issues:

closes #9383 - test_rolling_fixed.py::test_rolling_var_stability_12905
closes #11194 - test_decimal.py::test_df_constructor_convert_decimal_to_float_9873

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (24fccc4) to head (6b8feb2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20857      +/-   ##
==========================================
- Coverage   79.64%   79.64%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      223156   223156              
  Branches     2546     2546              
==========================================
- Hits       177731   177730       -1     
- Misses      44841    44842       +1     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b333ab7 into pola-rs:main Jan 23, 2025
13 of 14 checks passed
@lukemanley lukemanley deleted the various-tests branch January 23, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants