feat: Extract timezone info from python datetimes #20822
+92
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
bschoenmaeckers
changed the title
github-actions
bot
added
enhancement
bschoenmaeckers
force-pushed
the
python-datetime-timezone
branch
from
f33c0a8 to
837df0c
Compare
Apparently not on python 3.9 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20822 +/- ##
=======================================
Coverage 79.64% 79.64%
=======================================
Files 1571 1571
Lines 223156 223161 +5
Branches 2546 2543 -3
=======================================
+ Hits 177731 177742 +11
+ Misses 44841 44838 -3
+ Partials 584 581 -3 ☔ View full report in Codecov by Sentry. |
bschoenmaeckers
force-pushed
the
python-datetime-timezone
branch
from
d608c6e to
ebd1aec
Compare
2 tasks
|
The amount of timezone related issues showed me where the "infer" part needs to be. I will investigate which issues are relevant to this and add tests accordingly. |
bschoenmaeckers
force-pushed
the
python-datetime-timezone
branch
4 times, most recently
from
a242bd7 to
e8842e9
Compare
bschoenmaeckers
force-pushed
the
python-datetime-timezone
branch
from
e8842e9 to
161bc95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now extract the timezone from python as of #20660 (comment). It is however not yet clear to me when we have to infer the local timezone because all tests currently pass.
fixes #20766
closes #19509