-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make automatic use of Azure storage account keys opt-in #20652
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20652 +/- ##
==========================================
+ Coverage 79.00% 79.02% +0.02%
==========================================
Files 1559 1559
Lines 221216 221151 -65
Branches 2529 2530 +1
==========================================
- Hits 174761 174758 -3
+ Misses 45876 45814 -62
Partials 579 579 ☔ View full report in Codecov by Sentry. |
eprintln!("[CloudOptions::build_azure]: Permission check OK"); | ||
} | ||
return Ok(store); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication will now prioritize Entra ID (via the Python-side DefaultAzureCredential
if azure.identity
is installed). Using the storage account key will only happen if we get a permission error (above).
056089f
to
bea1a83
Compare
4afcb0f
to
46f6001
Compare
PR has been updated to remove the fallback mechanism, I don't have any ideas for a good way to determine whether the Azure object store has sufficient permissions - according to #20634 (comment), attempting to fetch a random file path is not good enough as there can be file-level RBAC configurations on the bucket. Instead, if |
ref #20634
POLARS_AUTO_USE_AZURE_STORAGE_ACCOUNT_KEY=1
is in the environment (note thatazure.identity
must also be installed as well, so thatCredentialProviderAzure
gets instantiated)