-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Serialize DataFrame/Series using IPC in serde #20266
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5480878
c
nameexhaustion 25f8650
c
nameexhaustion 5e0c4ef
c
nameexhaustion 892cef6
c
nameexhaustion b69e146
c
nameexhaustion 4070cb0
c
nameexhaustion 079046e
c
nameexhaustion da344db
c
nameexhaustion fcea7fe
c
nameexhaustion 315bdc5
fix test
nameexhaustion 8bb35ce
c
nameexhaustion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3562,4 +3562,41 @@ mod test { | |
assert_eq!(df.get_column_names(), &["a", "b", "c"]); | ||
Ok(()) | ||
} | ||
|
||
#[cfg(feature = "serde")] | ||
#[test] | ||
fn test_deserialize_height_validation_8751() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test was moved from Python - the existing test used an exact string representation of the previous JSON format, but that is changed after this PR. |
||
// Construct an invalid directly from the inner fields as the `new_unchecked_*` functions | ||
// have debug assertions | ||
|
||
use polars_utils::pl_serialize; | ||
|
||
let df = DataFrame { | ||
height: 2, | ||
columns: vec![ | ||
Int64Chunked::full("a".into(), 1, 2).into_column(), | ||
Int64Chunked::full("b".into(), 1, 1).into_column(), | ||
], | ||
cached_schema: OnceLock::new(), | ||
}; | ||
|
||
// We rely on the fact that the serialization doesn't check the heights of all columns | ||
let serialized = serde_json::to_string(&df).unwrap(); | ||
let err = serde_json::from_str::<DataFrame>(&serialized).unwrap_err(); | ||
|
||
assert!(err.to_string().contains( | ||
"successful parse invalid data: lengths don't match: could not create a new DataFrame:", | ||
)); | ||
|
||
let serialized = pl_serialize::SerializeOptions::default() | ||
.serialize_to_bytes(&df) | ||
.unwrap(); | ||
let err = pl_serialize::SerializeOptions::default() | ||
.deserialize_from_reader::<DataFrame, _>(serialized.as_slice()) | ||
.unwrap_err(); | ||
|
||
assert!(err.to_string().contains( | ||
"successful parse invalid data: lengths don't match: could not create a new DataFrame:", | ||
)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
ScalarColumn
I had the option of either using theserde::Serialize
impl fromAnyValue
, or converting it to a unit-length Series and dispatch to IPC. I chose the IPC option as theAnyValue
serde impl was missing quite a lot of dtypes, and using IPC would also give more assurance that the serialize behavior is the same with theSeriesColumn
.