[Service] Return the default RelayMinerDifficuly for services that have none. #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
service
Olshansk
approved these changes
Nov 16, 2024
| @@ -20,6 +21,13 @@ var _ = strconv.IntSize | |||
| func TestRelayMiningDifficultyQuerySingle(t *testing.T) { | |||
| keeper, ctx := keepertest.ServiceKeeper(t) | |||
| msgs := createNRelayMiningDifficulty(keeper, ctx, 2) | |||
|
|
|||
| // Add the corresponding services to the store to ensure that NotFound is returned | |||
There was a problem hiding this comment.
Great comment for this specific test.
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 926) |
github-actions
bot
added
devnet
push-image
bryanchriswhite
added a commit
that referenced
this pull request
Nov 18, 2024
* todo_beta/upnext: [C&P] Populate NumEstimatedComputeUnits and ClaimedUpokt of Claim and Proof events (#927) [Tokenomics] feat: add `dao_reward_address` param to tokenomics module (#922) chore: review feedback improvements chore: review feedback improvements [Service] Return the default RelayMinerDifficuly for services that have none. (#926) [Upgrade] Alpha TestNet v0.0.10 upgrade (#894) Update reviewdog.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
servicekeeper.GetRelayMinerDifficultyalways return a valid difficulty by defaulting to the base difficulty for newServices.Issue
Querying for a
RelayMiningDifficultycorresponding to a newServicedoes not return a valid one.This results in redundant code that aims to recreate the base
RelayMiningDifficulty.Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist