MBC3 RTC fixes #64
Draft
MBC3 RTC fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing the range tests will likely require a significant refactor, so parking this for now. |
TiKevin83
added a commit
to TiKevin83/gambatte-speedrun
that referenced
this pull request
Nov 22, 2020
TiKevin83
added a commit
to TASEmulators/gambatte-speedrun
that referenced
this pull request
Nov 23, 2020
porting Mbc3 RTC fixes from upstream pokemon-speedrunning#64
entrpntr
reviewed
Feb 12, 2021
| if (dataDh_ & 0x40) | ||
| haltTime_ = seconds; | ||
| else | ||
| time_.set(seconds, cc); |
There was a problem hiding this comment.
Just noting for whenever this gets picked up: the else block body in setS needs to stay as time_.reset(seconds, cc) to pass the subsecond writes tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to pass all tests in https://github.com/aaaaaa123456789/rtc3test . So far only the basic tests have been fixed.