Replace std::bindX and std::mem_fun with lambdas. #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see pokemon-speedrunning/gambatte-core#18
std::bind1st
,std::bind2nd
, andstd::mem_fun
were deprecated in C++11 and removed in C++17.GCC is the only compiler that allows using these functions regardless of the standard. Clang (both LLVM, and Apple Clang) and MSVC will error out on standard >=C++17. This is currently mainly an issue for LLVM Clang as starting LLVM 16, Clang defaults to C++17 and no standard used to be set in qmake.
This PR addresses this issue by using C++11 lambdas. This typically offers better performances compared to the alternative
std::bind
andstd::mem_fn
, and better extensibility if more methods need to be called in the same loop.Benchmark for reference
Here are some speed results for calling the same member function 1'000'000'000 times: