This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VQFN-32-1EP_5x5mm_P0.5mm_EP3.15x3.15mm #619
Add VQFN-32-1EP_5x5mm_P0.5mm_EP3.15x3.15mm #619
Changes from 1 commit
d003e40
e0031bc
eed83aa
35aed9b
6329435
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you choose those values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I had not updated all the values in this section from
VQFN-32-1EP_5x5mm_P0.5mm_EP3.1x3.1mm
.The grid values I have updated to
1.0, 1.0
to match the datasheet.I note that
paste_via_clearance
andEP_paste_coverage
have default values in the script, so for now I have removed them from this definition entirely. If that is not correct I would appreciate some guidance on how to select the values.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good choice on using defaults for the EP parameters.
I suggest to do the same with the grid.
This footprint is supposed to be build according to IPC spec (it has no
Texas_
prefix). With the current values (grid, thermal_vias, EP_num_paste_pads) you are mixing both. Resulting in vias below the paste which will lead to solder loss.Without the grid-setting, the vias are placed no-overlapping with the paste.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, I have removed the grid line to allow the defaults, as you say the vias now don't overlap with the paste.
I've added a screenshot of the ThermalVias variant to the top of the PR.