Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

add size definition for Analog CP-8-11 #433

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hvraven
Copy link
Contributor

@hvraven hvraven commented Sep 25, 2019

This adds the size definition for a 8 pin LFCSP package from Analog Datasheet

@codeclimate
Copy link

codeclimate bot commented Sep 25, 2019

Code Climate has analyzed commit 7a8a7fd and detected 0 issues on this pull request.

View more on Code Climate.

@evanshultz
Copy link
Collaborator

Thanks!

  1. You can remove line 42 for sure.
  2. Other commented lines can be removed.
  3. See the documentation for the related generator that is nearly ready at Add readme to gullwing generator #380. The Size definition format section shows a top-level entry which is missing in this file. Would you mind to add it?

I would like to wait to merge the footprint until after #422 is merged. After that PR is merged you will need to merge master into your branch, re-generate your footprint, and then update the footprint PR.

@evanshultz
Copy link
Collaborator

Oh. All dimensions in the YAML file are OK.

@hvraven
Copy link
Contributor Author

hvraven commented Sep 25, 2019

Cool, thanks for writing documentation for the generator. However the FileHeader is not yet supported by the NoLead generator, only by the Gullwing generator. Maybe I find some time to fix this later. Keeping this around until #422 is merged sounds like a good idea. I also cleaned up the unused definitions.

@chschlue
Copy link
Collaborator

#422

@myfreescalewebpage
Copy link
Contributor

@hvraven can you solve the branch conflict here, then ready for merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants