Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated UIGraphicsBeginImageContextWithOptions #818

Closed
wants to merge 1 commit into from

Conversation

murtaza64
Copy link

@murtaza64 murtaza64 commented Dec 14, 2023

As of iOS 17, UIGraphicsBeginImageContextWithOptions has been deprecated, and causes apps built with Xcode 15 to crash. The suggested fix is to use UIGraphicsImageRenderer, which this PR implements.

Copy link

@adozenlines adozenlines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should also consider previous versions of iOS where this API is still relevant. We don't experience any crashes, as outlined in the pull request. This sounds like it is something local to your code base or environment.

@murtaza64
Copy link
Author

What's the earliest iOS version you need to support? The replacement has been available since iOS 10. Unfortunately I'm not experienced enough with iOS to implement a version check

@murtaza64
Copy link
Author

Also, there are definitely at least a few other people experiencing crashes:
DylanVann/react-native-fast-image#1010

@murtaza64 murtaza64 closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants