Bugfix/1832 different date formats in personal info #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Not all tests have run for this PR. Please add the |
slavcho
approved these changes
Sep 22, 2024
ani-kalpachka
requested changes
Oct 2, 2024
src/common/util/date.ts
Outdated
| @@ -5,10 +5,7 @@ export const formatDate = 'dd MMM yyyy' | |||
| export const formatDatetime = 'dd MMM yyyy HH:mm:ss' | |||
|
|
|||
| export const formatDateString = (dateString: string | Date, language?: string) => { | |||
There was a problem hiding this comment.
Could you please remove "language?: string" from the parameters list since we are not going to need it anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #issue-1832
Motivation and context
Screenshots:
Testing
Steps to test
Affected urls
Environment
New environment variables:
NEW_ENV_VAR: env var detailsNew or updated dependencies:
dependency/namev1.0.0v2.0.0