Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change upload validation to avoid input error on form #1038

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

taylor-steve
Copy link
Contributor

Fixes #1025.

When using the if: proc ... validation, the default JavaScript validation isn't aware of the state change when you add a file (AFAIK). The approach here uses a custom validation, which will change the presentation slightly:

Screenshot 2024-03-12 at 12 54 00 PM

This is a tiny fix. Might be nice to handle the client-side issue, but maybe that's better left for when we do the bigger move off turbolinks?

@taylor-steve taylor-steve marked this pull request as ready for review March 12, 2024 21:35
@corylown corylown self-requested a review March 13, 2024 20:27
@corylown corylown merged commit c26b31d into main Mar 13, 2024
3 checks passed
@corylown corylown deleted the 1025-conditional-model-validation branch March 13, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional model validation is blocking file uploads via the UI
2 participants