Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally include proxy flags #59

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix: conditionally include proxy flags #59

merged 1 commit into from
Jan 27, 2022

Conversation

tomasgareau
Copy link
Contributor

I think #51 may have introduced a bug in the installers for python or ccppr_vsc -- when proxy was not set (or left to the default false), DIInstall python tried to call:

python3 -m venv .
bin/python -m pip install debugpy --proxy false

causing an error since --proxy false is not a valid argument for pip.

I suspect this is also the cause of #58.

This PR fixes that by conditionally adding the proxy flags (i.e., if proxy is "" or nil, it won't add any proxy flags to the commands).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants