fix: conditionally include proxy flags #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think #51 may have introduced a bug in the installers for
python
orccppr_vsc
-- whenproxy
was not set (or left to the defaultfalse
),DIInstall python
tried to call:causing an error since
--proxy false
is not a valid argument for pip.I suspect this is also the cause of #58.
This PR fixes that by conditionally adding the proxy flags (i.e., if
proxy
is""
ornil
, it won't add any proxy flags to the commands).