fix: parse ABI that is missing the outputs field

poanetwork · Jun 21, 2024 · 361f0c1 · 361f0c1
1 parent 29dcbbf
commit 361f0c1
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 2 deletions.
diff --git a/lib/abi/function_selector.ex b/lib/abi/function_selector.ex
@@ -178,9 +178,9 @@ defmodule ABI.FunctionSelector do
   def parse_specification_item(%{"type" => "function"} = item) do
     with %{
            "name" => function_name,
-           "inputs" => named_inputs,
-           "outputs" => named_outputs
+           "inputs" => named_inputs
          } <- item,
+         named_outputs = Map.get(item, "outputs", []),
          true <- simple_types?(named_inputs, item),
          true <- simple_types?(named_outputs, item) do
       input_types = Enum.map(named_inputs, &parse_specification_type/1)

diff --git a/test/abi_test.exs b/test/abi_test.exs
@@ -135,6 +135,39 @@ defmodule ABITest do
 
       assert parse_specification(abi) == expected
     end
+
+    test "parses an ABI without outputs" do
+      abi = [
+        %{
+          "type" => "function",
+          "stateMutability" => "view",
+          "name" => "assumeLastTokenIdMatches",
+          "inputs" => [
+            %{
+              "type" => "uint256",
+              "name" => "lastTokenId",
+              "internalType" => "uint256"
+            }
+          ]
+        }
+      ]
+
+      expected = [
+        %ABI.FunctionSelector{
+          function: "assumeLastTokenIdMatches",
+          method_id: <<231, 40, 120, 180>>,
+          type: :function,
+          inputs_indexed: nil,
+          state_mutability: :view,
+          input_names: ["lastTokenId"],
+          types: [uint: 256],
+          returns: [],
+          return_names: []
+        }
+      ]
+
+      assert parse_specification(abi) == expected
+    end
   end
 
   describe "find_and_decode/2" do