Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): adiciona input type #2241

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ingowagner
Copy link
Contributor

@ingowagner ingowagner commented Oct 8, 2024

< COMPONENTE >
po-button

< NÚMERO DA ISSUE >
DTHFUI-10009


PR Checklist [Revisor]

  • Padrão de Commit (Coeso, de acordo com o que está sendo realizado)
  • Código (Boas práticas, nome de variavéis/métodos, etc.)
  • Testes unitários (Cobre a situação implementada e coverage está mantido)
  • Documentação (Clara, objetiva e com exemplos caso necessário)
  • Samples (A implementação possui exemplo no Labs/Caso de uso)
  • Rodado em navegadores suportados (Chrome, FireFox, Edge)

Qual o comportamento atual?
Nao e possivel alterar o atributo type do button, ficando sempre fixo como type=button

Qual o novo comportamento?
Adiciona o Input type ao componente po-button.

Simulação

<po-button p-label="Type: button (default)"></po-button>
<po-button p-label="Type: submit" p-type="submit"></po-button>

Screenshot 2024-10-08 at 12 34 35 PM

@ingowagner ingowagner force-pushed the po-button/ingo branch 2 times, most recently from ff19d92 to 4170719 Compare December 3, 2024 19:34
@bruno-severino bruno-severino merged commit 9562105 into po-ui:master Dec 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants