Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirements.txt for python3 dependency installation #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kclejeune
Copy link

The existing version of requirements.txt fails when trying to build packages with wheels. I manually installed packages and then used pip freeze to create new versions.

Copy link
Owner

@pnpnpn pnpnpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biopython==1.76 and many other libraries are not needed.

@kclejeune
Copy link
Author

kclejeune commented May 26, 2020

The biopython==1.76 and many other libraries are not needed.

Could you list the specific libraries you’re referring to? They may not be direct requirements for your codebase but if it shows up in pip freeze then it’s important to include as a dependency to avoid version incompatibilities.

@kclejeune kclejeune requested a review from pnpnpn June 5, 2020 18:46
removed a few dependencies that were tied to my environment settings
@kclejeune
Copy link
Author

I'd like to reiterate emphasize the importance of these "unnecessary" libraries - they are not dependencies of your codebase, but they are necessary in order to reproduce a working environment if dependencies are updated in the future.

@pnpnpn
Copy link
Owner

pnpnpn commented Jun 5, 2020

I'd like to reiterate emphasize the importance of these "unnecessary" libraries - they are not dependencies of your codebase, but they are necessary in order to reproduce a working environment if dependencies are updated in the future.

That makes sense. I noticed that this is using latest version of gensim. Does it work with the current code? I think there has been significant change to the gensim API since gensim==0.13.2.

@kclejeune
Copy link
Author

I'd like to reiterate emphasize the importance of these "unnecessary" libraries - they are not dependencies of your codebase, but they are necessary in order to reproduce a working environment if dependencies are updated in the future.

That makes sense. I noticed that this is using latest version of gensim. Does it work with the current code? I think there has been significant change to the gensim API since gensim==0.13.2.

These dependencies work with all proposed changes on #15. I'll check if it works with the existing codebase and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants