Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug: entra app permission remove fails when service principal d… #6446

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes bug: entra app permission remove fails when service principal d… #6446

wants to merge 1 commit into from

Conversation

Saurabh7019
Copy link
Contributor

…oesn't exist. Closes #6291

@Saurabh7019 Saurabh7019 marked this pull request as ready for review October 22, 2024 19:28
@milanholemans
Copy link
Contributor

Thanks! We'll try to have a look at it ASAP!

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2024

@Saurabh7019 I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

@martinlingstuyl martinlingstuyl self-assigned this Nov 19, 2024
martinlingstuyl
martinlingstuyl approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Saurabh7019! I'll merge it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report: entra app permission remove fails when service principal doesn't exist
4 participants
@Saurabh7019 @milanholemans @Adam-it @martinlingstuyl