-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes defaultProperties method from various commands. Closes #6432 #6441
base: main
Are you sure you want to change the base?
Conversation
Thanks, we'll try to review it ASAP! |
@SmitaNachan I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SmitaNachan awesome work 👏👏👏
I noticed that we missed also booking business get
command which also has default properties but shouldn't. Do you think we could include this one as well so that we clear everything in one go
Also, unfortunately besides correcting the command and tests we will need to also update the command docs. In the docs we have the Response
section in which we show the output of the command. If we now removed the default properties from those commands the output will not get trimmed and we now need to include the additional properties in the text response as well
Hello @Adam-it |
@SmitaNachan Sorry for the late reply 🙏. I saw your comment but I was totally full with everything. Sure.
If you will have any kind of problem just ping me up however you want. |
@pnp/cli-for-microsoft-365-maintainers due to my short brake I am unassigning myself from this one so that it may be processed by someone else |
Removes
defaultProperties
method from various commands. Closes #6432