-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gym Env and Implement RL Training #203
Open
tztsai
wants to merge
17
commits into
pnnl:master
Choose a base branch
from
tztsai:rl-policy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,456
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tztsai
changed the title
Fix Gym Env and Implement PPO RL Training
Fix Gym Env and Implement RL Training
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gym.py
inpsl
to useBuildingEnv
to wrap anyBuildingEnvelope
system (the original version wraps any instance ofODE_NonAutonomous
, but in its implementation, it seems to assume that the system is aBuildingEnvelope
).ppo.py
andsac.py
(largely adopted from https://github.com/vwxyzjn/cleanrl) in therl
folder. Both DRL algorithms can successfully run in theBuildingEnv
environment.gym_dpc.py
andgym_nssm.py
where aDPCTrainer
orNSSMTrainer
can directly accept a gym environment as input and use aneuromancer.Trainer
to train a neural network in this environment.hybrid_control.py
as an attempt to implement the technical proposal inREADME.md
, illustrated bydiagram.svg
. Currently the program can successfully train a DPC policy in aBuildingEnv
, and insert its policy model as the actor network of an actor-critic PPO agent, and then continue the training in an RL workflow. This hybrid approach may have the benefit of improving the DPC policy by learning from long-term cumulative reward, as well as accelerating the DRL training by providing a pre-trained DPC policy model.