Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use C++17 standard, std::filesystem, upgrade newell gcc to 10.2.0 #57

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Use C++17 standard, std::filesystem, upgrade newell gcc to 10.2.0 #57

wants to merge 6 commits into from

Conversation

jaelynlitz
Copy link
Contributor

Closes #55 and #56

jaelynlitz
jaelynlitz commented Oct 21, 2023
View reviewed changes
CMakeLists.txt
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17 -lstdc++fs ")
set(CUDA_NVCC_FLAGS "-std=c++17")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from @pelesh on GitLab

Is this portable? What if we use compiler other than GCC? I think if you set CMake C++ and CUDA standards, you don't need to add these flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++17 Standard
1 participant
@jaelynlitz