Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix spack ubuntu CPU build #144

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Conversation

cameronrutherford
Copy link
Contributor

Adds --fail-fast to the spack install to avoid the installation running for any longer than it needs to

@cameronrutherford
Copy link
Contributor Author

Noticed the ubuntu build was failing in #131, so this is an attempt to speed up the rate of failure in those builds....

@cameronrutherford cameronrutherford changed the title Update spack_cpu_build.yaml Bugfix spack ubuntu CPU build May 17, 2024
@cameronrutherford
Copy link
Contributor Author

Not really sure why this build is now failing... Ideas:

  • Use a spack provided base image
  • Pin spack version
  • Re-use packages more aggressively

Still really unclear why this is happening since it's an error in getting the C compiler to even do anything

@cameronrutherford cameronrutherford force-pushed the spack-cpu-install-fail-fast branch from bed8256 to 033bb30 Compare June 5, 2024 18:02
@cameronrutherford cameronrutherford removed the request for review from jaelynlitz June 5, 2024 20:45
@cameronrutherford
Copy link
Contributor Author

Ready for review + merge after pipelines pass. Since this uses a newer gcc and ubuntu version, the whole build is happening from scratch this first time. Future runs should be quicker

@cameronrutherford
Copy link
Contributor Author

All green check marks, so I will merge once review is finished.

@jaelynlitz jaelynlitz merged commit 4cd1212 into develop Jun 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants