Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC line implementation #143
base: develop
Are you sure you want to change the base?
DC line implementation #143
Changes from 16 commits
321ec37
3f68f15
f83398e
9ede518
7342992
ac2bda9
d5e6ab3
6c72545
a8cf206
0e7d2e4
ea7d546
4e516ba
86b87fb
cdd65e0
71eb3b9
5875434
3e48fa8
6ca1d68
baa707e
c3ad0c1
79839e5
a388f32
b3fadc8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not thrilled about a lot of these variable names. Is there a better way to differentiate / describe these variables? The difference of 1 letter in a different case is easy to typo / miss, and the intention isn't clear from reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N
andn
are typically used in the context of a parallel implementation whereN
is the global size andn
is the local size. Perhaps, it is confusing here and this should be replaced. But, this is a big change that we need to do through another PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create an issue for this then? Perhaps naming
n_local_...
andn_global_...
would make more sense? A little more of a cumbersome name, but should be more readable.