Small spack changes to cleanup spack process on HPC Clusters #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronrutherford
added this to the 1.6.1 Python bindings + Documentation Release milestone
buildsystem/spack/load_spack.sh
Outdated
|
|
||
| # Use a directory based environment, and decorate command line | ||
| spack env create -d $SPACKENV $base/spack.yaml && |
There was a problem hiding this comment.
This is the main change.... No longer are we running spack env create before a cp command, we just do it all in one line using spack native commands.
cameronrutherford
changed the title
|
@jaelynlitz please review I think this is good to merge |
jaelynlitz
requested changes
Apr 23, 2024
cameronrutherford
force-pushed
the
cameron/spack-fixups
branch
from
9dac54d to
d67d661
Compare
|
@jaelynlitz please re-review |
jaelynlitz
approved these changes
May 22, 2024
cameronrutherford
force-pushed
the
cameron/spack-fixups
branch
from
af9879e to
08da641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
No specific issue being addressed here, just some quality of life changes to some of our spack scripts. This makes it so that the spack environment is created in a single line, and that there is no longer a
module purgethat is ran before config is loaded. This is helpful to prevent harmful environment modifications by our scripts where they might be unnecessary.If these changes are ok, we can extend this to other clusters as needed. Many of the whitespace changes were automatically made by my editor, and we can change / revert as needed. We don't really have any bash linting configuration or developer guidelines surrounding those files...