Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update petsc version installing_with_spack.md #123

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Update petsc version installing_with_spack.md #123

merged 2 commits into from
Mar 6, 2024

Conversation

nedpfeiffer
Copy link
Collaborator

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

It appears the Spack installation instructions are outdated. I received the following error:

ubuntu@workstation:~$ spack install exago@develop%gcc \
  ^openmpi ^[email protected]+coinhsl~mumps ^coinhsl+blas \
  ^[email protected]+mpi~hypre~superlu-dist~mumps+shared
==> Error: concretization failed for the following reasons:

   1. Cannot select a single "version" for package "petsc"
   2. Cannot satisfy 'petsc@:3.13'
   3. Cannot satisfy '[email protected]'
   4. Cannot satisfy '[email protected]:'
   5. Cannot satisfy '[email protected]:'
   6. Cannot satisfy '[email protected]:3.14'
   7. Cannot satisfy '[email protected]'
   8. Cannot satisfy '[email protected]:3.13'
   9. Cannot satisfy '[email protected]:'
        required because exago depends on [email protected]: when @1.6: 
          required because exago@develop%gcc ^coinhsl+blas ^[email protected]+coinhsl~mumps ^openmpi ^[email protected]~hypre+mpi~mumps+shared~superlu-dist requested explicitly 
   10. Cannot satisfy '[email protected]'
        required because exago@develop%gcc ^coinhsl+blas ^[email protected]+coinhsl~mumps ^openmpi ^[email protected]~hypre+mpi~mumps+shared~superlu-dist requested explicitly 
   11. Cannot satisfy '[email protected]:' and '[email protected]
        required because exago depends on [email protected]: when @1.6: 
          required because exago@develop%gcc ^coinhsl+blas ^[email protected]+coinhsl~mumps ^openmpi ^[email protected]~hypre+mpi~mumps+shared~superlu-dist requested explicitly 
        required because exago@develop%gcc ^coinhsl+blas ^[email protected]+coinhsl~mumps ^openmpi ^[email protected]~hypre+mpi~mumps+shared~superlu-dist requested explicitly 
   12. Cannot satisfy '[email protected]' and '[email protected]:
        required because exago depends on [email protected]: when @1.6: 
          required because exago@develop%gcc ^coinhsl+blas ^[email protected]+coinhsl~mumps ^openmpi ^[email protected]~hypre+mpi~mumps+shared~superlu-dist requested explicitly 
        required because exago@develop%gcc ^coinhsl+blas ^[email protected]+coinhsl~mumps ^openmpi ^[email protected]~hypre+mpi~mumps+shared~superlu-dist requested explicitly

Specifying petsc version 3.19 as the required version allowed me to continue installation.

@abhyshr
Copy link
Collaborator

abhyshr commented Feb 27, 2024

@cameronrutherford @jaelynlitz : Can you take a look at this PR when you get a chance.

Copy link
Contributor

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we have spack version constraints in ExaGO's package.py that capture this, but our documentation lacks here and struggles to keep up to date. Perhaps we should remove the PETSc version spec from these docs altogether?

@cameronrutherford
Copy link
Contributor

I'll wait for @jaelynlitz to get back from vacation to give a second opinion, but thanks for this @nedpfeiffer!! Great catch

jaelynlitz
jaelynlitz previously approved these changes Mar 5, 2024
Copy link
Contributor

@jaelynlitz jaelynlitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I agree with @cameronrutherford that we could probably remove the version from the docs and let the spack package handle the version, one less thing to remember to update. FYI @nedpfeiffer we are compatible with petsc 3.20 as well if you want to upgrade 😄

@nedpfeiffer nedpfeiffer dismissed stale reviews from jaelynlitz and cameronrutherford via b55a8d1 March 6, 2024 00:09
@cameronrutherford cameronrutherford merged commit 1189ad2 into pnnl:develop Mar 6, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants