Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get tests passing #632

Closed
wants to merge 1 commit into from
Closed

get tests passing #632

wants to merge 1 commit into from

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 15, 2024

I used import.meta.resolve in packages/mdsvex/src/index.ts, but that's only available in Node v18.19.0 / v20.6.0. I'm not sure if you're okay with that or not. If you want to support older versions you probably need to do something like change it back to require.resolve together with createRequire

Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: 57ffc79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Aug 15, 2024

commit: cae19f7

mdsvex

pnpm add https://pkg.pr.new/pngwn/MDsveX/mdsvex@632

pfm-parse

pnpm add https://pkg.pr.new/pngwn/MDsveX/pfm-parse@632

svast

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast@632

svast-stringify

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-stringify@632

svast-utils

pnpm add https://pkg.pr.new/pngwn/MDsveX/svast-utils@632

svelte-parse

pnpm add https://pkg.pr.new/pngwn/MDsveX/svelte-parse@632

Open in Stackblitz

@benmccann benmccann changed the title get tests mostly working get tests passing Aug 16, 2024
@pngwn
Copy link
Owner

pngwn commented Aug 17, 2024

I decided to go ahead and convert to vitest: #637

All working now i think.

Thanks @benmccann!

@pngwn pngwn closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants