removing comment

pmpailis · Nov 6, 2024 · db7b74f · db7b74f
1 parent 18dd34e
commit db7b74f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/server/src/main/java/org/elasticsearch/search/rank/RankBuilder.java b/server/src/main/java/org/elasticsearch/search/rank/RankBuilder.java
@@ -118,8 +118,6 @@ public int rankWindowSize() {
     /**
      * Transforms the specific rank builder (as parsed through SearchSourceBuilder) to the corresponding retriever.
      * This is used to ensure smooth deprecation of `rank` and `sub_searches` and move towards the retriever framework
-     *
-     * @return
      */
     @UpdateForV10(owner = UpdateForV10.Owner.SEARCH_RELEVANCE) // remove for 10.0 once we remove support for the rank parameter in SearchAPI
     @Nullable

diff --git a/x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/rrf/RRFRankBuilder.java b/x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/rrf/RRFRankBuilder.java
@@ -195,7 +195,7 @@ public RankFeaturePhaseRankCoordinatorContext buildRankFeaturePhaseCoordinatorCo
     @Override
     public RetrieverBuilder toRetriever(SearchSourceBuilder source, Predicate<NodeFeature> clusterSupportsFeature) {
         if (false == clusterSupportsFeature.test(RRFRetrieverBuilder.RRF_RETRIEVER_COMPOSITION_SUPPORTED)) {
-            return null; // should we throw instead?
+            return null;
         }
         int totalQueries = source.subSearches().size() + source.knnSearch().size();
         if (totalQueries < 2) {