addressing PR comments - adding validation for text_similarity_rerank…

…er retriever
pmpailis · Oct 7, 2024 · a740af1 · a740af1
1 parent d82cfcc
commit a740af1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/server/src/main/java/org/elasticsearch/TransportVersions.java b/server/src/main/java/org/elasticsearch/TransportVersions.java
@@ -236,7 +236,7 @@ static TransportVersion def(int id) {
     public static final TransportVersion INGEST_GEO_DATABASE_PROVIDERS = def(8_760_00_0);
     public static final TransportVersion DATE_TIME_DOC_VALUES_LOCALES = def(8_761_00_0);
     public static final TransportVersion TEXT_SIMILARITY_RERANKER_QUERY_REWRITE = def(8_762_00_0);
-  
+
     /*
      * STOP! READ THIS FIRST! No, really,
      *        ____ _____ ___  ____  _        ____  _____    _    ____    _____ _   _ ___ ____    _____ ___ ____  ____ _____ _

diff --git a/...elasticsearch/xpack/inference/rank/textsimilarity/TextSimilarityRankRetrieverBuilder.java b/...elasticsearch/xpack/inference/rank/textsimilarity/TextSimilarityRankRetrieverBuilder.java
@@ -117,6 +117,9 @@ public TextSimilarityRankRetrieverBuilder(
         List<QueryBuilder> preFilterQueryBuilders
     ) {
         super(retrieverSource, rankWindowSize);
+        if (retrieverSource.size() != 1) {
+            throw new IllegalArgumentException("[" + getName() + "] retriever should have exactly one inner retriever");
+        }
         this.inferenceId = inferenceId;
         this.inferenceText = inferenceText;
         this.field = field;
@@ -127,7 +130,6 @@ public TextSimilarityRankRetrieverBuilder(
 
     @Override
     protected TextSimilarityRankRetrieverBuilder clone(List<RetrieverSource> newChildRetrievers) {
-        assert newChildRetrievers.size() == 1;
         return new TextSimilarityRankRetrieverBuilder(
             newChildRetrievers,
             inferenceId,