decref searchhits

pmpailis · Oct 3, 2024 · 957fb65 · 957fb65
1 parent 1e6f3bc
commit 957fb65
Showing 1 changed file with 27 additions and 19 deletions.
diff --git a/server/src/test/java/org/elasticsearch/action/search/ExpandSearchPhaseTests.java b/server/src/test/java/org/elasticsearch/action/search/ExpandSearchPhaseTests.java
@@ -343,14 +343,18 @@ void sendExecuteMultiSearch(MultiSearchRequest request, SearchTask task, ActionL
             SearchHit hit = new SearchHit(1, "ID");
             hit.setDocumentField("someField", new DocumentField("someField", Collections.singletonList("foo")));
             SearchHits hits = new SearchHits(new SearchHit[] { hit }, new TotalHits(1, TotalHits.Relation.EQUAL_TO), 1.0F);
-            ExpandSearchPhase phase = new ExpandSearchPhase(mockSearchPhaseContext, hits, () -> new SearchPhase("test") {
-                @Override
-                public void run() {
-                    mockSearchPhaseContext.sendSearchResponse(new SearchResponseSections(hits, null, null, false, null, null, 1), null);
-                }
-            });
-            phase.run();
-            mockSearchPhaseContext.assertNoFailure();
+            try {
+                ExpandSearchPhase phase = new ExpandSearchPhase(mockSearchPhaseContext, hits, () -> new SearchPhase("test") {
+                    @Override
+                    public void run() {
+                        mockSearchPhaseContext.sendSearchResponse(new SearchResponseSections(hits, null, null, false, null, null, 1), null);
+                    }
+                });
+                phase.run();
+                mockSearchPhaseContext.assertNoFailure();
+            } finally {
+                hits.decRef();
+            }
         } finally {
             var resp = mockSearchPhaseContext.searchResponse.get();
             if (resp != null) {
@@ -387,17 +391,21 @@ void sendExecuteMultiSearch(MultiSearchRequest request, SearchTask task, ActionL
             SearchHit hit = new SearchHit(1, "ID");
             hit.setDocumentField("someField", new DocumentField("someField", Collections.singletonList("foo")));
             SearchHits hits = new SearchHits(new SearchHit[] { hit }, new TotalHits(1, TotalHits.Relation.EQUAL_TO), 1.0F);
-            ExpandSearchPhase phase = new ExpandSearchPhase(mockSearchPhaseContext, hits, () -> new SearchPhase("test") {
-                @Override
-                public void run() {
-                    mockSearchPhaseContext.sendSearchResponse(
-                        new SearchResponseSections(hits, null, null, false, null, null, 1),
-                        new AtomicArray<>(0)
-                    );
-                }
-            });
-            phase.run();
-            mockSearchPhaseContext.assertNoFailure();
+            try {
+                ExpandSearchPhase phase = new ExpandSearchPhase(mockSearchPhaseContext, hits, () -> new SearchPhase("test") {
+                    @Override
+                    public void run() {
+                        mockSearchPhaseContext.sendSearchResponse(
+                            new SearchResponseSections(hits, null, null, false, null, null, 1),
+                            new AtomicArray<>(0)
+                        );
+                    }
+                });
+                phase.run();
+                mockSearchPhaseContext.assertNoFailure();
+            } finally {
+                hits.decRef();
+            }
         } finally {
             var resp = mockSearchPhaseContext.searchResponse.get();
             if (resp != null) {