Skip to content

Commit

Permalink
[Test] Enable logging for AmazonHttpClient (elastic#116560) (elastic#…
Browse files Browse the repository at this point in the history
…116702)

If sending request fails locally without reaching the server, the
retryable exception is logged differently. This PR enables the logging
for this scenario.

Relates: elastic#88841 Relates: elastic#101608
(cherry picked from commit 5204902)

# Conflicts:
#	modules/repository-s3/src/internalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
  • Loading branch information
ywangd authored Nov 13, 2024
1 parent 4ad1b5b commit 88a1b69
Showing 1 changed file with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,10 @@ protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) {
}

@Override
@TestIssueLogging(issueUrl = "https://github.com/elastic/elasticsearch/issues/88841", value = "com.amazonaws.request:DEBUG")
@TestIssueLogging(
issueUrl = "https://github.com/elastic/elasticsearch/issues/88841",
value = "com.amazonaws.request:DEBUG,com.amazonaws.http.AmazonHttpClient:TRACE"
)
public void testRequestStats() throws Exception {
super.testRequestStats();
}
Expand Down Expand Up @@ -234,8 +237,10 @@ public void testAbortRequestStats() throws Exception {
assertEquals(assertionErrorMsg, mockCalls, sdkRequestCounts);
}

@TestIssueLogging(issueUrl = "https://github.com/elastic/elasticsearch/issues/101608", value = "com.amazonaws.request:DEBUG")
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/101608")
@TestIssueLogging(
issueUrl = "https://github.com/elastic/elasticsearch/issues/101608",
value = "com.amazonaws.request:DEBUG,com.amazonaws.http.AmazonHttpClient:TRACE"
)
public void testMetrics() throws Exception {
// Create the repository and perform some activities
final String repository = createRepository(randomRepositoryName(), false);
Expand Down

0 comments on commit 88a1b69

Please sign in to comment.