[#6] Added support for ClojureScript #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pmonks, please let me know what you think about this. |
2 tasks
|
@e18r just wanted to let you know that I’ve been traveling without a laptop these last few weeks. I haven’t forgotten about this, promise! 😄 |
|
@pmonks Unfortunately, in its current state, the library doesn't work in react native because hickory seems to have issues with it. Since cljs-http doesn't work with Node, I wonder if there are any use cases left. As for me, I abandoned the project of adding unfurling to Status. Thank you for all your help and until next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, @pmonks, this is it. I moved platform-independent code to
common.cljc, and platform-specific code toapi.cljandapi.cljs. I created a separated test suite inapi_test.cljs, which uses doo and karma to run the tests, as well as a Flask back end created to get rid of CORS issues. I haven't modified the README yet. I'll do it as soon as you approve my changes.In order to test, try running
./cljs.sh, which installs all the requirements, runs the test server and the tests. Please let me know if it doesn't work.