mpl: pass MPL's CFLAGS back to MPICH #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/ofi |
yfguo
force-pushed
the
test-configure
branch
from
839bd5e to
7bddd3b
Compare
|
test:mpich/ch4/ofi |
hzhou
approved these changes
Sep 26, 2024
| @@ -29,6 +29,7 @@ LT_PREREQ([2.2.6]) | |||
| PAC_PUSH_FLAG([CFLAGS]) | |||
| LT_INIT() | |||
| PAC_POP_FLAG([CFLAGS]) | |||
| PARENT_CFLAGS=${CFLAGS} | |||
There was a problem hiding this comment.
I think the usual name is SAVE_CFLAGS.
yfguo
force-pushed
the
test-configure
branch
3 times, most recently
from
269670b to
5ffbdac
Compare
MPL exports additional CFLAGS as MPL_CFLAGS. Only the ones that added by the MPL configure will be passed. The PAC_CONFIG_MPL macro will add them to CFLAGS.
yfguo
force-pushed
the
test-configure
branch
from
5ffbdac to
643e606
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PR#7074 consolidated SSE2 and AVX related optimization options into MPL's configure because only MPL explicitly use them. MPICH's CFLAGS no longer has those options. However, with Intel compilers, this does results in some performance degradation. Therefore, we need to propagate the CFLAGS in MPL back into the MPICH configure.
This PR creates a
MPL_CFLAGSin the localdefs that allows the PAC_CONFIG_MPL macro to add it to the main CFLAGS.This is an alternative and probably better solution than the 2nd commit in #7150 .
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.