Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): make react compiler happy #2771

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 15, 2024

If we were to follow eslint-react-compiler, should this be a solution?

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 10:22am

Copy link

codesandbox-ci bot commented Oct 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Oct 15, 2024

Size Change: +184 B (+0.2%)

Total Size: 91 kB

Filename Size Change
./dist/esm/react.mjs 1.44 kB +38 B (+2.71%)
./dist/react.js 1.48 kB +38 B (+2.64%)
./dist/system/react.development.js 1.6 kB +45 B (+2.89%)
./dist/system/react.production.js 878 B +13 B (+1.5%)
./dist/umd/react.development.js 1.6 kB +40 B (+2.56%)
./dist/umd/react.production.js 944 B +10 B (+1.07%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 932 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.19 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react/utils.mjs 746 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla.mjs 3.99 kB
./dist/esm/vanilla/utils.mjs 5.04 kB
./dist/index.js 242 B
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.1 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.29 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react/utils.development.js 860 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla.development.js 4.08 kB
./dist/system/vanilla.production.js 2.14 kB
./dist/system/vanilla/utils.development.js 5.25 kB
./dist/system/vanilla/utils.production.js 3.14 kB
./dist/umd/babel/plugin-debug-label.development.js 1.08 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla.development.js 5.32 kB
./dist/umd/vanilla.production.js 2.84 kB
./dist/umd/vanilla/utils.development.js 6.24 kB
./dist/umd/vanilla/utils.production.js 3.78 kB
./dist/utils.js 247 B
./dist/vanilla.js 5.22 kB
./dist/vanilla/utils.js 6.1 kB

compressed-size-action

Copy link

github-actions bot commented Oct 15, 2024

LiveCodes Preview in LiveCodes

Latest commit: 735b510
Last updated: Nov 25, 2024 10:21am (UTC)

Playground Link
React demo https://livecodes.io?x=id/3CLZBPNBY

See documentations for usage instructions.

@dai-shi
Copy link
Member Author

dai-shi commented Nov 26, 2024

/ecosystem-ci run

Copy link

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant