Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending fluid concept to fit CF & Standard formulations #1244

Open
wants to merge 55 commits into
base: develop
Choose a base branch
from
Open

Extending fluid concept to fit CF & Standard formulations #1244

wants to merge 55 commits into from

Commits on Oct 17, 2024

  1. MOD: Renaming classes and methods for compatibility with modelling fr… 

    …amework.
    @vlipovac
    vlipovac committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3f80872 View commit details
    Browse the repository at this point in the history

  2. MOD: Material constants are now data classes replacing chemical species.

    @vlipovac
    vlipovac committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8fffb9b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. MOD: Make hashable dict for material constants ordered.

    @vlipovac
    vlipovac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5b9e0af View commit details
    Browse the repository at this point in the history

  2. MIN: Moving material constants to porepy.compositional.materials

    @vlipovac
    vlipovac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    014fbf5 View commit details
    Browse the repository at this point in the history

  3. TEST: Adapting tests to new signature of material constants.

    @vlipovac
    vlipovac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    559a4b3 View commit details
    Browse the repository at this point in the history

  4. MOD: changing solution strategy to create a 1-phase, 1-component flui… 

    …d, instead of FluidConstants.
    @vlipovac
    vlipovac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    87437a8 View commit details
    Browse the repository at this point in the history

  5. MIN: Import and instantiation issues after change in material constants

    @vlipovac
    vlipovac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3fec45b View commit details
    Browse the repository at this point in the history

  6. MOD: Adapting usage of SolidConstants throughout package.

    @vlipovac
    vlipovac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4b93858 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. MOD: moving all functionality from chem_species.py to materials.py an… 

    …d deleting chem_species.
    @vlipovac
    vlipovac committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    0fce4f1 View commit details
    Browse the repository at this point in the history

  2. MOD: Adapted usage of FluidConstants to recent changes.

    @vlipovac
    vlipovac committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    32a768b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fluid_concep

    @vlipovac
    vlipovac committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3dc1964 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. MIN: Removing some unused mixin annotations.

    @vlipovac
    vlipovac committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    349d5d0 View commit details
    Browse the repository at this point in the history

  2. MOD: Adapting some remaining, untyped usage of fluid and solid consta… 

    …nts.
    @vlipovac
    vlipovac committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    c07a4d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. MOD: Refactor fluid constitutive laws to general fluid.

    @vlipovac
    vlipovac committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c72012d View commit details
    Browse the repository at this point in the history

  2. MIN: Changing argument names for fluid property function to match pp … 

    …convention.
    @vlipovac
    vlipovac committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e2c6c7f View commit details
    Browse the repository at this point in the history

  3. MIN: Shorten namespace of some objects in pp.compositional to pp.*

    @vlipovac
    vlipovac committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8bd3179 View commit details
    Browse the repository at this point in the history

  4. MOD: Adding FluidMixin to base models.

    @vlipovac
    vlipovac committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7c91748 View commit details
    Browse the repository at this point in the history

  5. TEST: All tests pass now.

    @vlipovac
    vlipovac committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    18a035e View commit details
    Browse the repository at this point in the history

  6. STY: mypy, flake8, isort, black

    @vlipovac
    vlipovac committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3ec6590 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'develop' into fluid_concept

    @vlipovac
    vlipovac committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1b1b78c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fluid_concept

    @vlipovac
    vlipovac authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4b719c4 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Eirik Keilegavlen <[email protected]>
    @vlipovac @keileg
    vlipovac and keileg authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8100f32 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Applying minor changes from review.

    @vlipovac
    vlipovac committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    61c300c View commit details
    Browse the repository at this point in the history

  2. Porepy Model Protocol (#1234) 

    * DOC: ModelGeometry protocol

* DOC: PorePyModel protocol

* DOC: Removed duplicating docstrings, DataSavingProtocol

* DOC: Made tests pass

* DOC: remarks after discussion

* MAINT: removed type: ignore

* DOC: Remove duplicate docstring, rewrite create_variables() docstring

* DOC: Docstrings for the protocols

* DOC: PorePyModel

* MAINT: isort, black, mypy

* MAINT: Black

* DOC: Minor improvements

* MAINT: flake8

* Changes after review

* DOC: Add more model-independent methods to Protocol

* Maint: Removed type: ignore here and there

* MAINT: Make static tests pass

* MAINT: _is_time_dependent added to the protocol

* MAINT: flake8

* DOC: Apply suggestions from code review

Co-authored-by: Ivar Stefansson <[email protected]>

* DOC: Updates after the review

* MAINT: Reverted garbage changes in the tutorial

* BLD: Protocol docstrings script

* DOC: Moved docstrings back to implementations

* DOC: Duplicated docstrings in protocol

* DOC: Applied review change

---------

Co-authored-by: Yury Zabegaev <[email protected]>
Co-authored-by: mariusnevland <[email protected]>
Co-authored-by: Ivar Stefansson <[email protected]>
    @Yuriyzabegaev @mariusnevland @IvarStefansson
    4 people authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    dfbc7ba View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. MOD: transferring conver_units to Units class (issue 1247)

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3275229 View commit details
    Browse the repository at this point in the history

  2. MOD: Renaming classes and methods for compatibility with modelling fr… 

    …amework.
    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    01cfabd View commit details
    Browse the repository at this point in the history

  3. MOD: Material constants are now data classes replacing chemical species.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6648647 View commit details
    Browse the repository at this point in the history

  4. MOD: Make hashable dict for material constants ordered.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0bf2b73 View commit details
    Browse the repository at this point in the history

  5. MIN: Moving material constants to porepy.compositional.materials

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8f0f8e3 View commit details
    Browse the repository at this point in the history

  6. TEST: Adapting tests to new signature of material constants.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ccc35e1 View commit details
    Browse the repository at this point in the history

  7. MOD: changing solution strategy to create a 1-phase, 1-component flui… 

    …d, instead of FluidConstants.
    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9855184 View commit details
    Browse the repository at this point in the history

  8. MIN: Import and instantiation issues after change in material constants

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a0c0721 View commit details
    Browse the repository at this point in the history

  9. MOD: Adapting usage of SolidConstants throughout package.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fc900d9 View commit details
    Browse the repository at this point in the history

  10. MOD: moving all functionality from chem_species.py to materials.py an… 

    …d deleting chem_species.
    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5ad1ef1 View commit details
    Browse the repository at this point in the history

  11. MOD: Adapted usage of FluidConstants to recent changes.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a182cbe View commit details
    Browse the repository at this point in the history

  12. MOD: Adapting some remaining, untyped usage of fluid and solid consta… 

    …nts.
    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bd8aa16 View commit details
    Browse the repository at this point in the history

  13. MOD: Refactor fluid constitutive laws to general fluid.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9f2c380 View commit details
    Browse the repository at this point in the history

  14. MIN: Changing argument names for fluid property function to match pp … 

    …convention.
    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ff53f37 View commit details
    Browse the repository at this point in the history

  15. MIN: Shorten namespace of some objects in pp.compositional to pp.*

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    95a08b7 View commit details
    Browse the repository at this point in the history

  16. MOD: Adding FluidMixin to base models.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ca91c68 View commit details
    Browse the repository at this point in the history

  17. TEST: All tests pass now.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    38a395d View commit details
    Browse the repository at this point in the history

  18. STY: mypy, flake8, isort, black

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d0c115c View commit details
    Browse the repository at this point in the history

  19. Apply suggestions from code review 

    Co-authored-by: Eirik Keilegavlen <[email protected]>
    @vlipovac @keileg
    vlipovac and keileg committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    eaa2c77 View commit details
    Browse the repository at this point in the history

  20. Applying minor changes from review.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    94bf9c6 View commit details
    Browse the repository at this point in the history

  21. MOD: transferring conver_units to Units class (issue 1247)

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7fe5a2a View commit details
    Browse the repository at this point in the history

  22. ENH: Introducing the FluidProtocol into the base PorePyModel

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5c043d5 View commit details
    Browse the repository at this point in the history

  23. FIX: Lost changes after rebase onto develop (with protocols).

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b0e7117 View commit details
    Browse the repository at this point in the history

  24. Mergde 'origin/fluid_concept' into fluid_concept.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4460b2f View commit details
    Browse the repository at this point in the history

  25. MIN: Docs of fluid protocol.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b61a416 View commit details
    Browse the repository at this point in the history

  26. MIN: Docs in fluid protocol

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5f62371 View commit details
    Browse the repository at this point in the history

  27. STY: flake8, black

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b6dc203 View commit details
    Browse the repository at this point in the history

  28. TEST: All tests pass now.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    495df0e View commit details
    Browse the repository at this point in the history

  29. testing

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8d6ec7c View commit details
    Browse the repository at this point in the history

  30. FIX: Inconsistent assignment of constructor in porepy models.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    da986bf View commit details
    Browse the repository at this point in the history

  31. MIN: Improving docs and clean-up.

    @vlipovac
    vlipovac committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a2a6c4f View commit details
    Browse the repository at this point in the history