Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRR: correctly separate the calculate and update #1132

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

HanatoK
Copy link
Contributor

@HanatoK HanatoK commented Oct 10, 2024

The previous implementation updates the internal states partially in calculate(), which should be done in update(). This commit fixes the issue.

Description

This PR refactors the DRR implementation by moving the update of the eABF grid and the estimators in the update() function from calculate().

Target release

I would like my code to appear in release v2.11

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

The previous implementation updates the internal states partially in
calculate(), which should be done in update(). This commit fixes the
issue.
@carlocamilloni carlocamilloni merged commit 81f78e3 into plumed:master Oct 11, 2024
8 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants