Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #17 fix opening credits start time #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Nov 28, 2021

it seems opening credits was removed due to following condition:

        # Skip clips entirely before the start point
        if start + duration < self.start_time:
            return

Moving start time of opening credits helps

@valerio-bozzolan
Copy link
Contributor

I tested this patch on my local computer and it just works as expected. Tried with:

./make-xges.py --opening-credits=intro-pepper.png asd presentation.xges

And it put my pepper in the intro as usual:

Screenshot_GIMP_pepper

I recommend in merging this.

(I'm not the maintainer)

@valerio-bozzolan
Copy link
Contributor

valerio-bozzolan commented Mar 3, 2024

Premising that I've done some code review, and I'm merging what I like in this fork:

https://github.com/valerio-bozzolan/bbb-render

Hoping to be useful, this pull request was merged in that fork, at this point:

valerio-bozzolan@53f9723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants