Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix import on bootstrap #111

Merged
merged 9 commits into from
Oct 21, 2023
Merged

Conversation

boazpoolman
Copy link
Member

What does it do?

Fix the importOnBootstrap feature

Why is it needed?

The importOnBootstrap feature is broken since 1.2 as per #109

How to test it?

I've included new integration tests in this PR.
They are currently failing with the same error as described in #109.
As soon as we've fixed those tests the PR can be merged and the issue will be fixed.

Related issue(s)/PR(s)

#109

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d101e3c) 0.00% compared to head (19f5ba1) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           master      #111        +/-   ##
=============================================
+ Coverage        0   100.00%   +100.00%     
=============================================
  Files           0         8         +8     
  Lines           0        27        +27     
  Branches        0         3         +3     
=============================================
+ Hits            0        27        +27     
Flag Coverage Δ
unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
playground/__tests__/helpers.js 100.00% <100.00%> (ø)
playground/config/plugins.js 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSACC MSACC merged commit a4b767f into master Oct 21, 2023
8 checks passed
@MSACC MSACC deleted the feature/fix-import-on-bootstrap branch October 21, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants