fix(pie): use readonly arrays for props as the library does not modif…

…y them
plouc · Nov 14, 2023 · 6dc6636 · 6dc6636 · vercel · Nov 14, 2023
1 parent 5306106
commit 6dc6636
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/pie/src/hooks.ts b/packages/pie/src/hooks.ts
@@ -31,7 +31,7 @@ export const useNormalizedData = <RawDatum extends MayHaveLabel>({
         Omit<ComputedDatum<RawDatum>, 'arc' | 'color' | 'fill'>
     >,
 }: Pick<CompletePieSvgProps<RawDatum>, 'id' | 'value' | 'valueFormat' | 'colors'> & {
-    data: RawDatum[]
+    data: readonly RawDatum[]
 }): Omit<ComputedDatum<RawDatum>, 'arc' | 'fill'>[] => {
     const getId = usePropertyAccessor<RawDatum, DatumId>(id)
     const getValue = usePropertyAccessor<RawDatum, number>(value)

diff --git a/packages/pie/src/types.ts b/packages/pie/src/types.ts
@@ -58,7 +58,7 @@ export interface ComputedDatum<RawDatum> {
 }
 
 export interface DataProps<RawDatum> {
-    data: RawDatum[]
+    data: readonly RawDatum[]
 }
 
 export interface PieTooltipProps<RawDatum> {
@@ -73,7 +73,7 @@ export type MouseEventHandler<RawDatum, ElementType = HTMLCanvasElement> = (
 export type PieLayerId = 'arcLinkLabels' | 'arcs' | 'arcLabels' | 'legends'
 
 export interface PieCustomLayerProps<RawDatum> {
-    dataWithArc: ComputedDatum<RawDatum>[]
+    dataWithArc: readonly ComputedDatum<RawDatum>[]
     centerX: number
     centerY: number
     radius: number
@@ -114,7 +114,7 @@ export type CommonPieProps<RawDatum> = {
     isInteractive: boolean
     tooltip: React.FC<PieTooltipProps<RawDatum>>
 
-    legends: LegendProps[]
+    legends: readonly LegendProps[]
 
     role: string
     renderWrapper: boolean
@@ -137,7 +137,7 @@ export type PieSvgProps<RawDatum> = DataProps<RawDatum> &
     Partial<CommonPieProps<RawDatum>> &
     SvgDefsAndFill<ComputedDatum<RawDatum>> &
     PieHandlers<RawDatum, SVGPathElement> & {
-        layers?: PieLayer<RawDatum>[]
+        layers?: readonly PieLayer<RawDatum>[]
         animate?: boolean
         motionConfig?: MotionProps['motionConfig']
         transitionMode?: ArcTransitionMode
@@ -148,7 +148,7 @@ export type CompletePieSvgProps<RawDatum> = DataProps<RawDatum> &
     CommonPieProps<RawDatum> &
     SvgDefsAndFill<ComputedDatum<RawDatum>> &
     PieHandlers<RawDatum, SVGPathElement> & {
-        layers: PieLayer<RawDatum>[]
+        layers: readonly PieLayer<RawDatum>[]
         animate: boolean
         motionConfig: MotionProps['motionConfig']
         transitionMode: ArcTransitionMode