Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used resource title instead of resource type in page title. #6402

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Faakhir30
Copy link
Contributor

@Faakhir30 Faakhir30 commented Oct 13, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6308

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit bca33bc
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/670fe530ed65cf0007eb78ce

@stevepiercy
Copy link
Collaborator

This needs review from @plone/volto-team. I'm not sure about inserting a - into the message ID. I don't know if that would be good, bad, or doesn't matter for a11y, @plone/volto-accessibility?

@JeffersonBledsoe
Copy link
Member

I'm not sure about inserting a - into the message ID. I don't know if that would be good, bad, or doesn't matter for a11y, @plone/volto-accessibility?

No problems that I'm aware of. It's a common pattern to use it to separate out 'sections' of a title and most screen readers will skip over it and add a gap in the read-out.

All that said, I'm not sure it's a needed change here (as already mentioned) as we don't use it elsewhere so let's keep it consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit mode <title> doesn't describe the name of the page but instead describes the content type
4 participants