Fix link in pop-up RelationsMatrix.jsx #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This link is outdated after #5809, and its anchor never existed. This PR corrects both issues.
✅ Deploy Preview for plone-components canceled.
|
|
@stevepiercy the selection of the toc is a bit strange with your link |
|
@ichim-david I get different results. The
|
|
Also in Sphinx and MyST, it is preferred to use the label, not the heading text, as that heading text may change, but the label almost never does. When the label changes, it is much easier to do a find and replace. |
ichim-david
approved these changes
Jun 10, 2024
|
@ksuess is the link with its anchor correct? I made an educated guess, but I'd like your feedback. |
|
Yes, https://6.docs.plone.org/volto/development/widget.html#widget-relation-field-label where the info is located. Thank you for bringing this up and taking time to find a solution! |
ksuess
approved these changes
Jun 11, 2024
sneridagh
added a commit
that referenced
this pull request
Jun 15, 2024
* main: (63 commits) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 (fix): export getFieldURL from Url.js in helpers (#6100) Improve container detection, `config.settings.containerBlockTypes` is no longer needed (#6099) Support nested directories in public folder add-on sync folders both … (#6098) Release 18.0.0-alpha.34 Add generated new declarations for a34, just in case (#6097) Release @plone/slate 18.0.0-alpha.13 Release @plone/registry 1.6.0 Release @plone/types 1.0.0-alpha.15 Add support for reading the add-ons `tsconfig.json` paths (#6096) Fixes #6046 pass proper defaults to align and size fields of Image block (#6093) bug fix. relations control panel. Restrict eglible relation targets a… (#6092) Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (#6088) Add optional `token` parameter to ploneClient initialization (#6077) Blocks Layout Navigator (#5642) Fix internalUrl Widget to Reflect Prop Changes via onChangeBlock (#6036) [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (#6095) Fix link in pop-up RelationsMatrix.jsx (#6085) Fix deselecting lists. (#6080) ...
sneridagh
added a commit
to aryan7081/volto
that referenced
this pull request
Jun 15, 2024
* main: (42 commits) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 (fix): export getFieldURL from Url.js in helpers (plone#6100) Improve container detection, `config.settings.containerBlockTypes` is no longer needed (plone#6099) Support nested directories in public folder add-on sync folders both … (plone#6098) Release 18.0.0-alpha.34 Add generated new declarations for a34, just in case (plone#6097) Release @plone/slate 18.0.0-alpha.13 Release @plone/registry 1.6.0 Release @plone/types 1.0.0-alpha.15 Add support for reading the add-ons `tsconfig.json` paths (plone#6096) Fixes plone#6046 pass proper defaults to align and size fields of Image block (plone#6093) bug fix. relations control panel. Restrict eglible relation targets a… (plone#6092) Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (plone#6088) Add optional `token` parameter to ploneClient initialization (plone#6077) Blocks Layout Navigator (plone#5642) Fix internalUrl Widget to Reflect Prop Changes via onChangeBlock (plone#6036) [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (plone#6095) Fix link in pop-up RelationsMatrix.jsx (plone#6085) Fix deselecting lists. (plone#6080) ...
sneridagh
added a commit
that referenced
this pull request
Jun 17, 2024
* main: (31 commits) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 (fix): export getFieldURL from Url.js in helpers (#6100) Improve container detection, `config.settings.containerBlockTypes` is no longer needed (#6099) Support nested directories in public folder add-on sync folders both … (#6098) Release 18.0.0-alpha.34 Add generated new declarations for a34, just in case (#6097) Release @plone/slate 18.0.0-alpha.13 Release @plone/registry 1.6.0 Release @plone/types 1.0.0-alpha.15 Add support for reading the add-ons `tsconfig.json` paths (#6096) Fixes #6046 pass proper defaults to align and size fields of Image block (#6093) bug fix. relations control panel. Restrict eglible relation targets a… (#6092) Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (#6088) Add optional `token` parameter to ploneClient initialization (#6077) Blocks Layout Navigator (#5642) Fix internalUrl Widget to Reflect Prop Changes via onChangeBlock (#6036) [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (#6095) Fix link in pop-up RelationsMatrix.jsx (#6085) Fix deselecting lists. (#6080) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This link is outdated after #5809, and its anchor never existed. This PR corrects both issues.
📚 Documentation preview 📚: https://volto--6085.org.readthedocs.build/