-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hindi translation in Volto #6016
Conversation
✅ Deploy Preview for plone-components canceled.
|
❌ Deploy Preview for volto failed. Why did it fail? →
|
@iFlameing needs a final i18n script run. |
@sneridagh @stevepiercy we should probably list the supported languages somewhere in documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I can't review the translation itself. Please invite other Hindi speakers to check it if you want.
Agreed, but what would it look like? Would it be just a list of supported languages, links to the repos where you can see which languages are supported, or a combination of both? Classic UI and Volto have different supported languages, 69 versus 14 plus 1 from this PR, so we need to make that distinction. I'd suggest adding content to Internationalization and Localization in the main documentation. We should also add a step to each process for adding a new language, where the contributor adds it to the listing in the main documentation, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iFlameing Nice!
@stevepiercy @iRohitSingh Will work on the Hindi translation in Plone core during the sprint. |
That would be awesome. We have documentation for how to add languages for Plone Classic UI, but I am not certain if it is correct. Please feel free to submit PRs for that as well. |
That docs are OK. I reviewed them some time ago and they are still OK. I am waiting for the final approval from Weblate to have a Free plan there and include that documentation too. Anyway, Weblate can be used also to contribute Classic UI translation right now. Not for Volto (there are still some issues). |
@iFlameing we need to update too: https://github.com/plone/volto/blob/main/packages/volto/src/constants/Languages.js#L7 Thanks! |
And that step needs to be added to the overview in https://6.docs.plone.org/volto/development/i18n.html |
I also noticed that https://6.docs.plone.org/volto/development/i18n.html#broad-overview mentions |
Done in f767979. I also cleaned up grammar and syntax in the docs. |
See PR plone/documentation#1664 |
@sneridagh done from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iFlameing There is a failing unit test which needs to be updated with a new snapshot that includes Hindi in the list.
@davisagli help! How to do that? It ain't in the Volto docs. |
@stevepiercy There should be a prompt to update the snapshots when the tests are run as documented here: https://6.docs.plone.org/volto/contributing/testing.html#run-jest-tests-on-volto-core |
Done in db23888. Thank you! |
If they are mentioned somewhere, it should be only as a "how does it work". Those JSON files are the |
Fix #6015