Import/export group mappings #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (these were already being exported).
Because these cannot currently[1] be set via Plone (NotImplemented exception in Products.PloneLDAP.mixins.groupmgmt), these must be set via the LDAPUserFolder in the ZMI, and should be saved/restored with the rest of the LDAP settings. These are stored as the '_groups_mapping' dict in the LDAPUserFolder object; it's easiest to export this as a string and parse it with ast during import. [1] Fixed in collective/Products.PloneLDAP@9a90f98, but no new release has been cut yet.
|
Changelog entry is missing. I have no opinion from the functional pov. I'am not deep enough into p.a.ldap to make a decision here. |
Also fix markup in README.
|
Updated CHANGES & README. |
|
Since it looks clean and is documented I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because these mappings (LDAP group to Plone role) cannot currently be set via the Plone Users and Groups control panel (
NotImplementedexception inProducts.PloneLDAP.mixins.groupmgmt), they must be set via the LDAPUserFolder in the ZMI, and should be saved/restored with the rest of the LDAP settings upon import/export.(I fixed the NotImplemented error in collective/Products.PloneLDAP@9a90f98, but they have not yet made a new release, and it is still useful to import/export these group mappings -- e.g. I use it for global groups that give people editor, manager, etc. rights on all our Plone sites, just by loading our LDAP profile.)
Also import some other settings that were being missed, mentioned in #8 and #10. This is only a partial fix for #8 (no UI yet for those settings) but at least they are now properly imported & exported.