Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use src layout to fix editable install with pip #384

Closed
wants to merge 2 commits into from

Conversation

mauritsvanrees
Copy link
Member

See plone/meta#172

This uses a clone of the plone.app.uuid src-layout branch to test that two such packages together work. Seems fine locally.

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

Replaced by PR #385, although the current PR would still be fine on top of that.

@thet
Copy link
Member

thet commented May 6, 2024

This would mess up the GitHub history or at least make it more difficult to browse through the history.
But if it fixes problems playing together with standard tools, I'm fine with that. We probably would want do that for all Plone packages and within an coordinated effort.

@jensens
Copy link
Member

jensens commented May 7, 2024

I think this one is outdated. @mauritsvanrees ok to close?

@mauritsvanrees
Copy link
Member Author

Yes, we can close. This is something to pick up again for Plone 7 when moving to native namespaces.

@jensens jensens deleted the src-layout branch May 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants