Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with events portlet rendering when thumbs disabled (#332) #333

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

alecpm
Copy link
Member

@alecpm alecpm commented Jun 16, 2021

See #332, plone/plone.app.contenttypes#486, and PR plone/plone.app.contenttypes#603).

This PR is against 3.2.x, but the commit should merge cleanly against master and 3.x.

@mister-roboto
Copy link

@alecpm thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@alecpm
Copy link
Member Author

alecpm commented Jun 16, 2021

@jenkins-plone-org please run jobs

@jensens jensens merged commit ba4daed into 3.2.x Jun 18, 2021
@jensens jensens deleted the 332.bugfix branch June 18, 2021 10:33
@jensens
Copy link
Member

jensens commented Jun 18, 2021

@alecpm may you provide a PR targeting master as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants