Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ILeadImageBehavior and IRichTextBehavior interfaces were the name change was forgotten. #681

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

thet
Copy link
Member

@thet thet commented Nov 24, 2023

... these are some coincidentally grep/rg findings.

@thet thet requested review from jensens and pbauer November 24, 2023 18:00
@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@thet
Copy link
Member Author

thet commented Nov 24, 2023

@jenkins-plone-org please run jobs

@thet thet requested a review from gforcada November 24, 2023 19:14
@petschki
Copy link
Member

petschki commented Mar 5, 2024

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees merged commit 4d0a239 into master Apr 23, 2024
13 checks passed
@mauritsvanrees mauritsvanrees deleted the fix-behavior-interfaces branch April 23, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants